Skip to content

[Windows] Set nvme_vhba_device_ops_spec13 "Not Applicable" on ESXi 8.0.2 and later #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 23, 2025
Merged

[Windows] Set nvme_vhba_device_ops_spec13 "Not Applicable" on ESXi 8.0.2 and later #705

merged 10 commits into from
May 23, 2025

Conversation

Tomorrow9
Copy link
Member

@Tomorrow9 Tomorrow9 commented May 7, 2025 •
edited
Loading

On vSphere 8.0.2 and later with VM hwv 21 or higher, nvme_vhba_device_ops_spec13 will not run.

Test Results (Total: 5, Passed: 4, Skipped: 1, Elapsed Time: 01:55:30)
+-----------------------------------------------------------------+
| ID | Name                        |   Status         | Exec Time |
+-----------------------------------------------------------------+
|  1 | deploy_vm_bios_nvme_e1000e  |   Passed         | 00:19:12  |
|  2 | paravirtual_vhba_device_ops |   Passed         | 00:12:38  |
|  3 | nvme_vhba_device_ops        |   Passed         | 01:19:53  |
|  4 | nvme_vhba_device_ops_spec13 | * Not Applicable | 00:00:44  |
|  5 | nvme_disk_hot_extend_spec13 |   Passed         | 00:02:52  |
+-----------------------------------------------------------------+

@Tomorrow9 Tomorrow9 added this to the 3.3 milestone May 7, 2025
@Tomorrow9 Tomorrow9 marked this pull request as draft May 7, 2025 06:11
@Tomorrow9 Tomorrow9 force-pushed the fix_win_server_nvme branch from 209f81a to 4ffe9ab Compare May 7, 2025 06:30
@Tomorrow9 Tomorrow9 marked this pull request as ready for review May 9, 2025 05:29
@Tomorrow9 Tomorrow9 requested a review from keirazhang May 9, 2025 07:17
keirazhang
keirazhang reviewed May 14, 2025
View reviewed changes
@Tomorrow9 Tomorrow9 force-pushed the fix_win_server_nvme branch 2 times, most recently from a36edd1 to f3d4af0 Compare May 20, 2025 05:35
keirazhang
keirazhang reviewed May 21, 2025
View reviewed changes
Tomorrow9 added 10 commits May 23, 2025 07:13
@Tomorrow9
set nvme_vhba_device_ops_spec13 not applicable
0b782a8 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
enable NVMe spec 1.3 when it's not enabled by default
666212e 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
change when conditions
0b9c57d 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
add get nvme spec
07c5bbf 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
add get nvme spec version
a6727a4 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
also add for hot extend
65f31ec 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
change to check guest ID
286c253 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
fix syntax issue
924b432 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
address comments
dfa4bc3 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9
remove guest os type check
f70c78d 
Signed-off-by: dw035535 <[email protected]>
@Tomorrow9 Tomorrow9 force-pushed the fix_win_server_nvme branch from e6d8fba to f70c78d Compare May 23, 2025 07:18
keirazhang
keirazhang approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9 Tomorrow9 merged commit 6eaa6ff into vmware:main May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomorrow9 @keirazhang